> On April 21, 2013, 3:47 p.m., Thomas Baumgart wrote: > > kmymoney/models/accountsmodel.cpp, line 65 > > <http://git.reviewboard.kde.org/r/110022/diff/1/?file=138922#file138922line65> > > > > Am I missing something here? You set this boolean to false, set it to > > true in only one spot and return immediately afterwards. The only time you > > check this flag it is always false. So to me this simply is a NOP.
See below. I haven't done a revised patch at this stage, as I think I'm waiting on Cristian (17 April), who wants to '...come up with a more elegant fix.' > On April 21, 2013, 3:47 p.m., Thomas Baumgart wrote: > > kmymoney/models/accountsmodel.cpp, line 89 > > <http://git.reviewboard.kde.org/r/110022/diff/1/?file=138922#file138922line89> > > > > .. and here the check for the flag to be false. How could it ever get > > true here? > > > > Looking at it, I would simply remove all the flag business and simply > > return if the account is already there (as you do). Agreed and done. All tests OK. I think what I'd done was to add the return later, without looking at the consequence. A lesson to be learned. - Allan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110022/#review31383 ----------------------------------------------------------- On April 15, 2013, 11:53 a.m., Allan Anderson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110022/ > ----------------------------------------------------------- > > (Updated April 15, 2013, 11:53 a.m.) > > > Review request for KMymoney. > > > Description > ------- > > BUG:317655 - Re-importing a categories list QIF file results in duplicated > categories. Also, when creating sub-categories, some may appear twice or more > times in Categories view. > > These problems showed up with a single users categories list QIF file. The > re-importing problem is fixed by the > /kmymoney/converter/mymoneyqifreader.cpp change. > > @@ -906,7 +906,7 @@ void MyMoneyQifReader::processCategoryEntry(void) > } > > // check if we can find the account already in the file > - MyMoneyAccount acc = kmymoney->findAccount(account, MyMoneyAccount()); > + MyMoneyAccount acc = kmymoney->findAccount(account, parentAccount); > > Even without any re-importing, there was a further problem, where > third-level(plus) sub-categories get duplicated. With the following simple > file - > "!Type:Cat > NUtilities:Telephone:Cell:A > DCell Phone > E > ^" > the "N" line is dealt with recursively, and initially, all the categories get > created. However, what happens then is that the second part is dealt with, > and the next lower level is created again, etc. > > Initially, during this recursive process, the categories have not yet been > added to the KMM file, so I add them to a new addedCategoriesList, which is > scanned on each pass, to avoid this duplication. Because the process is > recursive, I made the list static, to ensure the higher levels are retained > between passes when descending the tree. > > The problem is not confined to importing. If that "N" line category tree is > created manually, in one entry, or during .kmy file loading, the third and > lower levels get duplicated/triplicated. > > The problem manifests itself only in the Categories view. Within the rest of > KMM, the categories are created and maintained correctly. > > > This addresses bug 317655. > http://bugs.kde.org/show_bug.cgi?id=317655 > > > Diffs > ----- > > kmymoney/converter/mymoneyqifreader.cpp f42b12b > kmymoney/models/accountsmodel.h 38f9f2c > kmymoney/models/accountsmodel.cpp 3679314 > > Diff: http://git.reviewboard.kde.org/r/110022/diff/ > > > Testing > ------- > > Numerous test case QIF files created and imported. Also, as the problem > affected my live data file, that, too, was used for testing. > > > Thanks, > > Allan Anderson > >
_______________________________________________ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
