----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121288/ -----------------------------------------------------------
(Updated Jan. 4, 2015, 3:13 nachm.) Review request for KMymoney. Repository: kmymoney Description (updated) ------- So the upgrade routine is not executed starting from version 0 - which is useless as the database should be the most recent version anyway. Also removed the version param from createTables(int version). It was not used and was totaly useless as createTables() calls upgradeDb(). This is also a workaround for bug 341304 as the upgradeToV1() won't be called after creation of tables anymore. The bug persists if the user has a version 0 database. CCBUG: 341304 REVIEW: 121288 Diffs (updated) ----- kmymoney/mymoney/storage/mymoneydatabasemgrtest.cpp 80ff5a725e41e2a344cf32019b22803059ab9f93 kmymoney/mymoney/storage/mymoneystoragesql.h ae79b484186e700367f9a4362ffd19772825cf22 kmymoney/mymoney/storage/mymoneystoragesql.cpp 3b82d2b45623ed0e4d3e8cba7e6dc7364ed50f9e Diff: https://git.reviewboard.kde.org/r/121288/diff/ Testing ------- make test only one fail left (see comments) XFAIL : MyMoneyDatabaseMgrTest::testBadConnections() Will fix when correct behaviour in this case is clear. Loc: [/home/christian/Develop/kmymoney/kmymoney/mymoney/storage/mymoneydatabasemgrtest.cpp(106)] Thanks, Christian David
_______________________________________________ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
