----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129790/#review101858 -----------------------------------------------------------
I've done code reading (only). Looks good to me besides that one comment. I cannot comment on the algorithm because I don't have knowledge about the financial mechanics at this point. kmymoney/reports/querytable.cpp (line 1159) <https://git.reviewboard.kde.org/r/129790/#comment68146> Please fix indentation of the basic block beginning here and ending at the corresponding while() statement. - Thomas Baumgart On Jan. 7, 2017, 8:50 nachm., Łukasz Wojniłowicz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129790/ > ----------------------------------------------------------- > > (Updated Jan. 7, 2017, 8:50 nachm.) > > > Review request for KMymoney. > > > Bugs: 250471 > http://bugs.kde.org/show_bug.cgi?id=250471 > > > Repository: kmymoney > > > Description > ------- > > This new report presents capital gains calculated using FIFO method and is > displayed in table. > > > Diffs > ----- > > kmymoney/mymoney/mymoneyreport.h 7397a0f > kmymoney/mymoney/mymoneyreport.cpp 642145a > kmymoney/reports/listtable.cpp 72b605f > kmymoney/reports/querytable.h 7e2bfa1 > kmymoney/reports/querytable.cpp e44f74c > kmymoney/views/kreportsview.cpp c9c9a12 > > Diff: https://git.reviewboard.kde.org/r/129790/diff/ > > > Testing > ------- > > > Thanks, > > Łukasz Wojniłowicz > >