----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129831/#review102175 -----------------------------------------------------------
Ship it! Ship It! - Thomas Baumgart On Jan. 14, 2017, 1:53 nachm., Łukasz Wojniłowicz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129831/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2017, 1:53 nachm.) > > > Review request for KMymoney. > > > Repository: kmymoney > > > Description > ------- > > 1) setCellTip merged into setDataCell, > 2) don't set up model with tooltips if ChartDataLabels is false, > 3) run justifyModelSize only once for each dataset, > 4) check coordinatePlane()->diagram()->datasetDimension() only once for > each dataset, > 5) use setItemData instead of setData. > > > Diffs > ----- > > kmymoney/reports/kreportchartview.h 25216a2 > kmymoney/reports/kreportchartview.cpp ce274bd > > Diff: https://git.reviewboard.kde.org/r/129831/diff/ > > > Testing > ------- > > Investment Price Graph and other line graphs. > > > Thanks, > > Łukasz Wojniłowicz > >