https://bugs.kde.org/show_bug.cgi?id=459020
Bug ID: 459020 Summary: noError and 2 Other Issues Product: kmymoney Version: git (master) Platform: Other OS: All Status: REPORTED Severity: minor Priority: NOR Component: general Assignee: kmymoney-devel@kde.org Reporter: librestep...@gmail.com Target Milestone: --- 1. Remove noError. The variable noError in MyMoneyQifWriter::writeInvestmentEntry seems unnecessary. Here is its declaration at the top level of the function: bool noError = true; There are 10 “if (noError) {” lines. There is one place where noError is given a value, aside from the declaration statement, but that value is not used: noError = false; return; 2. Shadow Variable. kmymoney/plugins/ofx/import/nodeparser.cpp has “list” declared on lines 78 and 81. The second(inner) “list” is visible for lines 81-88. The first(outer) “list” is visible for lines 78-90, except for the scope of the second “list”. I suggest that the second(inner) “list” be renamed “list3” for clarity. 3. Argument Name Mismatch in kmymoney/plugins/ofx/import/ofxpartner.cpp. The first argument to the definition of function OfxHttpRequest on line 284 is “type”. I suggest it be changed to “method” to match the .h file. It should also be changed on line 322. The argument refers to HTTP request methods, such as "get". See https://developer.mozilla.org/en-US/docs/Web/HTTP/Methods The function is used with the argument "POST" on line 396 of kmymoney/plugins/ofx/import/dialogs/konlinebankingsetupwizard.cpp -- You are receiving this mail because: You are the assignee for the bug.