http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4222
Paul Poulain <paul.poul...@biblibre.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |ian.walls@bywatersolutions.
| |com,
| |paul.poul...@biblibre.com
--- Comment #18 from Paul Poulain <paul.poul...@biblibre.com> 2011-08-03
09:46:55 UTC ---
Some QA comments :
The database update says :
+ $dbh->do("ALTER TABLE items ADD COLUMN nonpublicnote MEDIUMTEXT");
+ $dbh->do("ALTER TABLE deleteditems ADD COLUMN nonpublicnote MEDIUMTEXT");
and the mySQL adds the field at the end of the items table :
`stocknumber` varchar(32) default NULL,
+ `nonpublicnote` mediumtext default NULL,
There is already a field called itemnotes in the items table.
For consistency/clarity I would prefer to have the nonpublicnote next to the
itemnotes, so :
+ $dbh->do("ALTER TABLE items ADD COLUMN nonpublicnote MEDIUMTEXT AFTER
itemnotes");
+ $dbh->do("ALTER TABLE deleteditems ADD COLUMN nonpublicnote MEDIUMTEXT
AFTER itemnotes");
and kohastructure modified accordingly.
2nd topic :
+ $dbh->do("UPDATE marc_subfield_structure SET
kohafield='items.nonpublicnote' WHERE (kohafield IS NULL OR kohafield = '') AND
tagfield='952' AND tagsubfield='x'");
=> in UNIMARC, there is non-public note, so nothing specific to do here.
=> I feel the UPDATE can be dangerous = if someone has items mapped to
something different than 952, or 952$x used for something else (i've seen the
kohafield IS NULL OR kohafield = '', ++ for this security), there may be side
effect.
I would prefer to have :
* nothing done in the database
* a clear warning in the "print "Upgrade to $DBversion done (...)", like
"Upgrade to $DBversion done (<b>New field : items.nonpublicnotes. Please go to
admin > frameworks > and map this field to your MARC non public note. It will
appear on circ desc</b>)"
* a visible explanation in the release notes
Ian/chris/Srdjan your opinion ?
--
Configure bugmail:
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
