http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5131
Paul Poulain <paul.poul...@biblibre.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #4759|0 |1
is obsolete| |
--- Comment #5 from Paul Poulain <paul.poul...@biblibre.com> 2011-08-03
13:32:06 UTC ---
Created attachment 4821
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4821
proposed patch (passed QA)
QA comment
Will mark as "passed QA" but I have a few comments though:
* it's more perlish to write
$x= value if $cond;
rather than
if ($cond) {
$x=value;
}
* The list is hardcoded, so if one day a new sorting is added, we will have to
add the sorting here as well (but there's no other option, I agree)
--
Configure bugmail:
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
