http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6253
Paul Poulain <paul.poul...@biblibre.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |paul.poul...@biblibre.com
--- Comment #25 from Paul Poulain <paul.poul...@biblibre.com> 2011-10-12
14:49:52 UTC ---
QA comment
* those changes are made in a core part of Koha. I'm quite hesitating pushing
such a change 2 weeks before a release (but i'm not RM for 3.6 ;-) ). I fear
some side-effect could be missed.
* One of the changes that could have consequences is:
- $sql.= do { local $"=') AND (';
+ $sql.= do { local $"=') OR (';
(in SearchInTable)
doesn't this silent switch from AND to OR have possible side-effects ?
I see 2 possible effects:
* loss of performances X_indexed = something AND Y_notindexed = SMTHelse
result in a X index search while X_indexed = something OR Y_notindexed =
SMTHelse won't. That could be a real problem !
* different results. Of course A and B is different from A or B
Maybe there's something i'm missing, but please clarify !
Note : SearchInTable are also/only used in Budgets.pm and Contract.pm
--
Configure bugmail:
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
