http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13161

Katrin Fischer <katrin.fisc...@bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32934|0                           |1
        is obsolete|                            |
  Attachment #32956|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fisc...@bsz-bw.de> ---
Created attachment 32957
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32957&action=edit
[PASSED QA] Bug 13161 - Report name should be mandatory when editing saved
reports

When Bug 2969 made report name required for SQL reports, it did so only
for new reports. This patch makes the same requirement true when editing
existing reports.

Other changes:

- Removed unused "type" setting from edit screen (already removed from
  creation form).
- Added form field size attribute to report name field to match creation
  form.
- Moved SQL textarea into its own fieldset and marked it as required,
  matching the report creation form.

To test, apply the patch and edit an existing saved SQL report. You
should be prevented from saving your report with either the report name
or SQL field blank. Test with JavaScript enable and disabled.

Confirm that after entering valid data your report runs correctly.
Compare the new SQL report form with the update SQL report form. They
should be structured the same.

Signed-off-by: Nick Clemens <n...@quecheelibrary.org>
Signed-off-by: Katrin Fischer <katrin.fischer...@web.de>
Passes tests and QA script. Works as described.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to