http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648
Tomás Cohen Arazi <tomasco...@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomasco...@gmail.com --- Comment #62 from Tomás Cohen Arazi <tomasco...@gmail.com> --- Jonathan, I like the patch set, but there are two minor things remaining: - Missing the kohastructure.sql addition - We should really stick with the adopted naming schema for tables. Even if it will not be consistent with the current table names for acquisitions (we should, at some point just rename them). I would accept 'aqorder_users', but the ideal one would be 'aquisition_order_users', that would map to Koha::Acquisition::Order::Users. I'm open to discussing the naming schema and I know this bug has been here before the guidelines have been accepted. It is just a minor refactoring that i will accept as PASSED-QA. Thanks! -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/