http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423
M. Tompsett <mtomp...@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37197|0 |1 is obsolete| | --- Comment #9 from M. Tompsett <mtomp...@hotmail.com> --- Created attachment 37435 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37435&action=edit Bug 13423: Untranslatable strings in serials-edit.tt and serials-recieve.tt This patch removes unused code: * barcode_check() function, with untranslatable strings * commented call to this function To test: 1. Apply the patch 2. Check serials receive, no changes shall be detected NOTE: I did not run this test plan. Verification steps ------------------ 1. Find out where barcode_check is used. $ git grep barcode_check -- This is only in serials-edit.tt and serials-receive.tt 2. This patch only affects serials-edit.tt, so check who put the <!--onsubmit="return barcode_check()">--> $ git blame -L130 koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt -- note the commit related number. 3. Check out the commit. $ git show 77b64098 -- should show bug 5917, but the patches on bugzilla don't have the change nicely, so... 4. Hunt through the pages to find the change. -- Note: it is part of a "new file" diff! 5. Since this code hasn't been running since it was added... 6. apply the patch 7. run koha-qa test tools Signed-off-by: Mark Tompsett <mtomp...@hotmail.com> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/