http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6190
M. de Rooy <m.de.r...@rijksmuseum.nl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch Status|Signed Off |Passed QA
--- Comment #35 from M. de Rooy <m.de.r...@rijksmuseum.nl> 2011-11-14 12:45:42
UTC ---
Some QA remarks (not blocking approval):
systempreferences.pl
This script is now only used for Local use. Adding a line for Patrons is no
longer useful.
patrons.pref
Just a practical question: How does a user know the name of a field to exclude,
e.g. B_address2 ? Could you show the fields in a popup when clicking on a link
or so? I realize that the same holds for BorrowerMandatoryField. Maybe a small
follow up?
memberentry.pl
regex, use of o modifier: Perl will not recompile the pattern unless an
interpolated variable that it contains changes. You can force Perl to skip the
test and never recompile by adding a /o (which stands for "once") after the
trailing delimiter. The regex here does not contain a variable. Actually, I
wonder if you need this regex at all here.
Thank you for work and numerous rebasing!
--
Configure bugmail:
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
