http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14189
Eivin Giske Skaaren <eskaa...@yahoo.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39112|0 |1 is obsolete| | --- Comment #10 from Eivin Giske Skaaren <eskaa...@yahoo.no> --- Created attachment 39462 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39462&action=edit Bug 14189 refactor after failed QA. 1) Renamed to "head-searchbox". 2) Good suggestion, I have included it once in doc-head-close.inc. 3) For the algorithm to work when there are just 2 boxes we need to know if the first tab was clicked and since this is JS and run when a href is clicked the easiest way was to send the index as a parameter. 4) Pure JS is faster than jQuery and this code will run on every pageload and I don't think jQuery would make it any clearer than the used document.getElementsByClassName("head-searchbox"). For the rest of the JS it does not rely on names since all searchboxes of the class "head-searchbox" are put into the array "searchboxes". If a new page with any number of searchboxes is added to Koha later this should still work without modification. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/