http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836
--- Comment #14 from Julian Maurice <julian.maur...@biblibre.com> 2011-11-23 16:06:43 UTC --- It's much more beautiful like this! But I have some remarks: - Some image files in CSS are not in my local repository and don't come with the patch (img/arrow-*.png). This causes "full_numbers" pagination to have large empty space before or after labels ("First", "Back", etc.) - The first patch provides datatables for opac and intranet, so it would be great to have your work for opac too - The initial goal of this bug is to provide only the javascript library and other stuff (css, images, ...) but no tables using it, so patches contain only new files and could be easy to apply. Maybe you can separate your patch in two parts (and remove the modif on serials-home.tt so we can apply both patches from bug 6836 without applying patch from bug 6838) - If I don't use the 'sDom' property, the display is completely broken, so it has to be fixed - Using the default pagination type, at the bottom we have the two buttons (previous and next) and a right border, immediately followed by the div border (very minor bug) - I prefer images from datatables.net rather than the ones used with tablesorter, but it's just a matter of taste (In reply to comment #12) > I'm a little concerned about the significant increase in the plugin size: > About > 13K for tablesorter.js (17K if you count the pager plugin too) versus 70K for > the datatables base plugin plus 15K for the custom configuration file. But I > guess it's a trade-off for the increased functionality... Good point, I haven't noticed that. But it seems that DataTables is still faster than tablesorter. For example, on authorised values admin page, with large list of values (~1000), tablesorter sometimes caused firefox freezes and DataTables don't (but maybe it's just a firefox issue, I don't know) It certainly have to be tested. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/