http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981
Jonathan Druart <jonathan.dru...@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38241|0 |1 is obsolete| | Attachment #38242|0 |1 is obsolete| | Attachment #38243|0 |1 is obsolete| | Attachment #38244|0 |1 is obsolete| | Attachment #38245|0 |1 is obsolete| | Attachment #39504|0 |1 is obsolete| | --- Comment #51 from Jonathan Druart <jonathan.dru...@biblibre.com> --- Created attachment 39848 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39848&action=edit Bug 7981 - Remove HomeOrHoldingBranchReturn syspref This patch removes HomeOrHoldingBranchReturn syspref and makes circ/returns.pl respect branch circulation rules from C4::Circulation::GetBranchItemRule. Also transfer slip notice should reflect this. Default should always be to return item to home branch. Test plan: - make sure syspref 'AutomaticItemReturn' is set to 'false' - unset 'Default checkout, hold and return policy' or set 'Return policy' to 'Item returns home' - checkout an item and do a checkin from different branch than items homebranch - verify that you're prompted with a transfer message to item's home branch and that print slip matches - set 'Return policy' to 'Item returns to issuing library' - do a checkout and a checkin from branch different than item's home branch - verify that you're not prompted with a transfer message and that holding library is your current branch Signed-off-by: Kyle M Hall <k...@bywatersolutions.com> Follow-up: - Added 3 tests in t/db_dependent/Circulation_Branches.t to test AddReturn policies - Removed HomeOrHoldingBranchReturn from sysprefs.sql - Added notice on removing syspref in updatedatabase QA edits: - removed trailing whitespace in tests - moved branchname lookup from returns.pl to template Signed-off-by: Jonathan Druart <jonathan.dru...@biblibre.com> Signed-off-by: Mirko Tietgen <mi...@abunchofthings.net> Signed-off-by: Jonathan Druart <jonathan.dru...@koha-community.org> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/