http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12372
--- Comment #9 from Barton Chittenden <bar...@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #5) > I am not an expert at all of the debian scripts, but it seems that in > others, there are 2 errors raised if the usage is incorrect: > > > I would suggest to > die "Missing instance name..." > if the number of arg is not correct and > warn "Unknown instance $name." > if is_instance returns 0. > > Ccing Tomas to be sure I am not wrong. Ok, I've followed the convention set by koha-enable as closely as possible. In the context of the script, it didn't make sense to have the "Unknown instance" message be a warning. We're only processing a single instance, and if we don't die when we get a bad instance name, we'll get all of the calls to xmlstartlet and the call to mysql throwing confusing messages to stderr, and the script will fail anyway. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
