http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809
Jonathan Druart <jonathan.dru...@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41850|0 |1 is obsolete| | --- Comment #58 from Jonathan Druart <jonathan.dru...@bugs.koha-community.org> --- Created attachment 41899 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41899&action=edit Bug 9809: [QA Follow-up] Remove an erroneous call to GetReserveFee The call to GetReserveFee in opac-reserve.pl is useless in its current form. The first parameter undef takes care of receiving 0. But note that the user is warned correctly for the charge via param variable RESERVE_CHARGE on the opac form. When the hold is placed, AddReserve calls GetReserveFee. So if the routine would work correctly, we would not need this extra call in opac-reserve in the whole place. Unfortunately, the routine is not working correctly. I will submit a fix for GetReserveFee under a new report (14702). Test plan: [1] Add a hold fee to some category. [2] Check the warn for placing a hold on such a book in OPAC. [3] Observe that the actual fee is not charged. This is a current bug and it will be addressed on report 14702. Signed-off-by: Marcel de Rooy <m.de.r...@rijksmuseum.nl> Signed-off-by: Kyle M Hall <k...@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.dru...@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/