http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310
--- Comment #45 from Kyle M Hall <k...@bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #38)
> Comment on attachment 46862 [details] [review]
> Bug 14310 [QA Followup] - Adapt existing code to use new methods
>
> Review of attachment 46862 [details] [review]:
> -----------------------------------------------------------------
>
> ::: C4/Reserves.pm
> @@ +1178,4 @@
> > } else {
> > + # FIXME: Why are we doing this? Should this be resuming
> > the hold,
> > + # or maybe suspending it indefinitely?
> > + $hold->set( { suspend_until => undef } )->store();
>
> Indeed, this is weird.
> If suspend_until is defined, it should be a date.
I've found the one and only path that executes this code. If you have a
suspended hold with a resume date, and clear the resume date, then click
"Update hold(s)" the action is to change the suspension from one with a resume
date to an indefinite suspension! I'll update the FIXME to document this
instead.
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
