https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
Kyle M Hall <k...@bywatersolutions.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Signed Off
--- Comment #47 from Kyle M Hall <k...@bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #46)
> Kyle,
> I have squashed some patches (they failed qa tools: FAIL
> Koha/Borrower/Modification.pm FAIL git manipulation: The file has been added
> and deleted in the same patchset) and added tests for the new modules.
> However, I do not understand why you overload the method
> Koha::Patron::Modifications->new, this should not be needed
>
> Moreover, the methods of Koha::Patron::Modifications should now use
> snake_case (as they use Koha::Object), but it's outside the scope of this
> bug.
I also don't know why I did that ; )
I will post a followup to remove the new() method, as it is not needed. We
should file a bug to fix the method names fo Koha::Patron::Modifications.
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
