https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390
--- Comment #52 from Jacek Ablewicz <a...@biblos.pk.edu.pl> --- (In reply to Marcel de Rooy from comment #49) > (In reply to Kyle M Hall from comment #48) > > (In reply to Katrin Fischer from comment #45) > > > > How to solve this? Can we remove the issue id in accountlines after > > > > switching to F? Or should UpdateFine no longer update a F record > > > > although it > > > > has the right issue id, but add a new record? > > > > > > I think it should add a new line as it's a 'new fine'. If we differentiate > > > between F and FU cleanly, we can keep the issue_id too, I think? > > > > Katrin has is exactly. If the same checkout goes overdue twice, the patron > > should have two separate fines ( and each one will show a different due date > > for the same checkout ). > > > > This new followup will stop UpdateFine from updating closed out fines. > > We are coming closer to a solution! > But please note that we need type F (imo) in the totalamount calculation and > the max fine reduction. We should focus on what happens next in UpdateFine. IMO adding the filter (for FU, or FU|O|M ?) in if ( $rec->{issue_id} == $issue_id ) { should do the trick. > The test $data->{'amount'} != $amount is not sufficient. Here we should > exclude type F somehow. This test is kind of broken by itself (not always reliable, Bug 17138) but excluding F fines in there will not be sufficient IMO - it would prevent updating of the wrong fine record (in case when the one in $data is an incorrect match), but the right fine record update may get skipped too in such case. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/