https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509
Jonathan Druart <jonathan.dru...@bugs.koha-community.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
CC| |jonathan.dru...@bugs.koha-c
| |ommunity.org
--- Comment #17 from Jonathan Druart <jonathan.dru...@bugs.koha-community.org>
---
2 quick comments:
1/ Maybe it would be better to have only 1 syspref, or at least squash them
into the same syspref block (in the .pref file)
2/ It would be great to move GetBorrowersToSatisfyHold to the Koha namespace
and return objects instead.
I don't think they are blocker, but recommended.
I am failing it because you do not provide tests for the changes you made in
subroutines.
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
