https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224
--- Comment #36 from Aleisha Amohia <aleishaamo...@hotmail.com> --- Hi Owen, (In reply to Owen Leonard from comment #34) > I think this is a great new feature. A few issues and suggestions: > > - The preference should be retrieved via the template instead of in the Perl > script: > > https://wiki.koha-community.org/wiki/Coding_Guidelines#HTML7: > _use_system_preference_TT_plugin > > - The date in the checkin message should be formatted using the KohaDates > plugin. > - On the circulation page, I think it makes more sense to put the patron > note in the column which shows the "Checked in" message since that's where > the librarian would be looking for confirmation of the transaction. > I have implemented all these changes in the latest patch. > Since there is no way to find out what note was attached to something you > just checked in on returns.pl, I wonder if the notification shouldn't work > the same as the hold notice: In a blocking modal? I am working on a follow-up feature in Bug 17698 that allows a 'seen' system for the patron notes - similar to how we approve tags and comments made in the OPAC. I think this suggestion would be best implemented in that patch rather than this one if that's okay with you (would like to get this signed off and passed so I can finish 17698)! Thanks Aleisha -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/