https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015
--- Comment #14 from Mehdi Hamidi <mehdi.ham...@inlibro.com> --- (In reply to Josef Moravec from comment #13) Hello Josef, thank you for testing our patches. I will push a fix for errors you mentioned very soon. As for your concerns : >- the need to run generate_discrete_calendar.pl should be somehow documented >in >UI, adding holidays does not work without it and the can't know why I added a warning to let the user know about that. As for why you can't add holidays, it's because we need to have the date in the database beforehand, which means if the table is empty, there's date to edit. Holidays are just date where the column isopen=0. >Ad point 3 in your test plan: It would be better not to rely on existing >>branchcodes, but use TestBuilder to make one you need Our calendar needs to have valid branchcodes where their date are already in table discrete_calendar. Using TestBuilder gives random branchcodes so the dates cannot be retrieved from database since they are generated by generate_discrete_calendar.pl and add_days_discrete_calendar.pl. If you have a suggestion to bypass the hard coded branchcodes, let us know! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/