https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17970
--- Comment #2 from Jonathan Druart <jonathan.dru...@bugs.koha-community.org> --- Created attachment 59423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59423&action=edit Bug 17970: Fix GetPreparedLetter behavior if nothing to substitute >From C4::Letters::GetPreparedLetter: my $tables = $params{tables}; my $substitute = $params{substitute}; $tables || $substitute || $repeat or carp( "ERROR: nothing to substitute - both 'tables' and 'substitute' are empty" ), return; So if the parameter tables or substitute is passed but does not contain anything, it will not warn as expected. Test plan: 1/ Apply the patch with tests 2/ Confirm that they do not pass 3/ Apply this patch 4/ Confirm that the tests now pass -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/