https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698

Jonathan Druart <jonathan.dru...@bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |ASSIGNED
                 CC|                            |jonathan.dru...@bugs.koha-c
                   |                            |ommunity.org

--- Comment #12 from Jonathan Druart <jonathan.dru...@bugs.koha-community.org> 
---
Aleisha,
I have rebased your patch on top of the ones I have submitted on bug 14224.
You should take a look to apply some changes, for instance:
1/ Return a to_json
2/ Check the existence of the DB columns before inserting them
3/ Use "AFTER" in the ADD column sql query (to enforce fields order)
4/ I do not think checkout_notes should be a new module. I'd say it should go
to circ
5/ Make sure the strings are translatable

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to