https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18014
Julian Maurice <julian.maur...@biblibre.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #59871|0 |1
is obsolete| |
--- Comment #20 from Julian Maurice <julian.maur...@biblibre.com> ---
Created attachment 59882
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59882&action=edit
Bug 18014: AddAuthority should respect AUTO_INCREMENT
Instead of using the MAX(authid)+1 logic, AddAuthority should just save
the record and get the new id. The authid column is an autoincrement.
This eliminates problems where a newly assigned authid also refers to a
previously deleted record. (And it will not cause problems when refining
the dontmerge functionality on report 9988.)
Note: ModAuthority also calls AddAuthority to update an existing record; in
that case we should not create a new record even if the record should not
be found any more (which should be exceptional).
This patch also simplifies handling of 001 in the authority record: in all
cases this field is updated now; no need to check its contents.
Test plan:
[1] Run t/db_dependent/AuthoritiesMarc.t
[2] Add a new authority record via the interface
Signed-off-by: Marcel de Rooy <m.de.r...@rijksmuseum.nl>
Signed-off-by: Mark Tompsett <mtomp...@hotmail.com>
Signed-off-by: Julian Maurice <julian.maur...@biblibre.com>
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
