https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461
Kyle M Hall <k...@bywatersolutions.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Signed Off
--- Comment #56 from Kyle M Hall <k...@bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #55)
> In my opinion, this patchset is not ready to be QAed. Lot of changes should
> be done to meet our coding guidelines.
Jonathan, can you be more specific? That sounds like QA to me ; )
I've been working on the feature since 2012. It's already gone through one full
rewrite because Koha's coding guidelines had moved on so much since it was
initially written.
If you want another signoff, that's fine. But you specifically wrote "Lot of
changes should be done to meet our coding guidelines" which is not a task for a
signer. That's a task for a QA'er and I'll really need some actionable comments
if I am to make any changes!
If you want another sign-off, please set status to needs sign-off. Otherwise
the status can go back to failed qa.
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
