https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Marc Véron <ve...@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #28 from Marc Véron <ve...@veron.ch> --- Sorry, there is still something wrong (example see below). And I think it would be a good idea to put the whole "hint" part in an include file that can be re-used. At the moment we have code duplication in several tt files. For exammple in maninvoice.tt line 381 is obsolete In line 382, instead of a <\span> there should be a <span class="hint"> Line 383 displays only the first of the separators, should display all of them. In line 385, the <span> should be a <span class="hint"> Line 389 should be enclosed in <span class="hint"> .... </span> Then I have one more issue regarding translatability (sorry, I was not aware before): If you want to change it, click <a href="/cgi-bin/koha/admin/preferences.pl?tab=&op=search&searchfield=DigitSeparator">here </a> This will split the sentence in Pootle, translators will have: "If you want to change it, click " and a stray "here" It is much better for translatability not to split sentences by HTML tags. What do you think about the following? <a href="/cgi-bin/koha/admin/preferences.pl?tab=&op=search&searchfield=DigitSeparator">Click here to edit separators</a> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/