https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17738
Marcel de Rooy <m.de.r...@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64330|0 |1 is obsolete| | --- Comment #17 from Marcel de Rooy <m.de.r...@rijksmuseum.nl> --- Created attachment 64749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64749&action=edit Bug 17738: Replace GetReservesFromBorrowernumber with Koha::Patron->get_holds This patch replace the different calls to GetReservesFromBorrowernumber with a calls to Koha::Patron->get_holds. In some places we need to get a restricted set of holds, that's why we process a search on this holds returned by ->get_holds (on the found status for instance). The changes are quite trivial and reading the diff should be enough to catch bugs. Test plan: I would suggest to test this patch with patches from bug 17736 and bug 17737, to place different kind of holds (biblio and item level, future and past). Then do a whole workflow to detect bug, view a record, delete record, order, place a hold on an item which has been ordered, etc. The hold's informations should always be the same without or without these patches. Tested both patches together, works as expected. Signed-off-by: Marc VĂ©ron <ve...@veron.ch> Signed-off-by: Kyle M Hall <k...@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.r...@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/