https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662
--- Comment #133 from David Cook <dc...@prosentient.com.au> --- (In reply to Josef Moravec from comment #129) > Started testing, from first view I can see these issues: > > 1) RDF::Query is not in dependencies but used in various files > > 2) There are some style issues etc, could be catched easily by qa tools > > 3) Module UUID (package libuuid-perl) is packaged in version 0.05 for > jessie, but version 0.27 needed as you use the sub "uuid", this version is > packaged for stretch (which is released for few days now) > > 4) You use oai-pmh-harvester.yaml filename everywhere, but in > /debian/templates/koha-conf-site.xml.in it is 'oai_pmh_harvester.yaml' (with > underscores) - should be consistant > > 5) The message "Test succesfull!" should be more visible, you could use > "dialog message" classes to make it standard koha message > > > But the main think is: It does work well! ;) > > Not tested RDF harvesting, as I had no luck to install Fuseki properly :( 1) Ok, I'll add the RDF::Query dependency in a new patch. 2) Could you elaborate on the style issues? I went to https://wiki.koha-community.org/wiki/QA_Test_Tools, but the configure dependency step is risky and it looks set up to be used on Debian (and I'm on openSUSE although I should try out kohadevbox again) so I might hold off trying the tools for now. 3) I only use uuid() in two places, so I'll go back and make those bits compatible with UUID 0.05. 4) I'll add that to a new patch as well. Thanks for catching that one! 5) Makes sense! I've split the difference and done both, and added to a new patch! -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/