https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826
Tomás Cohen Arazi <tomasco...@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #91 from Tomás Cohen Arazi <tomasco...@gmail.com> --- This patch set is actually pretty simple and is not changing any behaviour (besides the side effect of recording the account offsets on each operation that involves charges/payments). It passes the usual QA tests, and opens the door for really cool and missing features in Koha (see the blocked bugs and it becomes obvious). My only observation would be that the 'type' column values should somehow be better controlled (possibly an ENUM, or better a FK to a separate table). This would set a clearer path for eventual added flexibility and avoiding migration/upgrades nightmares. Congrats Kyle! -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/