https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19196
Marcel de Rooy <m.de.r...@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #30 from Marcel de Rooy <m.de.r...@rijksmuseum.nl> --- (In reply to Tomás Cohen Arazi from comment #29) > What do you suggest? I thought doing it 'inline' was better. Keep in mind > that the 'register' sub is the only sub, and it contains the 'helpers' > definitiions. The 'helpers' are the only important thing here. > If you prefer, I can move them POD into a separate section like here: > > http://cpansearch.perl.org/src/JBERGER/Mojo-IOLoop-ForkCall-0.16/lib/ > Mojolicious/Plugin/ForkCall.pm > > but I still prefer this way. OK. You have a reason. Personally I would not prefer it, but it should not be a blocker. Passing it back to RM for final decision. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/