https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021
Marcel de Rooy <m.de.r...@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #32 from Marcel de Rooy <m.de.r...@rijksmuseum.nl> --- QA Comment: GetOverduesForBranch Please add a test. You make some fundamental changes here. koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt - <input type="hidden" name="totals[% line.accountlines_id %]" value="[% line.totals %]" /> Not sure. Why do yo remove this line ? New code: + my $accounts = Koha::Account::Lines->search({ borrowernumber => $borrowernumber, }, { order_by => ['accounttype'] }); + my @accounts; + while ( my $account = $accounts->next ) { This does not look very nice. Can we get more confusion on $account, @accounts or $accounts ? Renaming @accounts here might be the least we can do? No blocker on itself. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/