https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317
--- Comment #195 from Tomás Cohen Arazi <tomasco...@gmail.com> --- (In reply to Jonathan Druart from comment #193) > Some more: > > 1. This looks wrong > 260 here_link => "/cgi-bin/koha/ill/ill-requests.pl" > > url should be in template I'd say The path shouldn't need to be added manually, I'd say any option is wrong, fixed anyway in an upcoming patch. > 2. This is not used, you are using an ajax call > 219 } elsif ( $op eq 'illlist') { > 220 # Display all current ILLs > > 221 my $requests = $illRequests->search(); > 222 > 223 $template->param( > > 224 requests => $requests > > 225 ); This is not used and is removed on an upcoming patch. > 3. 257 media => [ "Book", "Article", "Journal" ], > Is this used? This is used as a fallback in case the backends don't implement their own list. Needs to be kept (e.g. for the Dummy backend to work). > 4. > Config.pm > 312 die "No DEFAULT_FORMATS has been defined in koha-conf.xml, but > UNMEDIATEDILL is active." > 313 if ( $unmediated && > !$configuration->{default_formats}->{default} ); > > Not used yet, please remove Yup, removed in an upcoming patch. > 5. 794 \"YEAR(placed) = YEAR(NOW())" > This looks like a mysqlism True. But I cannot find any option to specify the same behaviour in SQL::Abstract or the DBIC docs. The very same line of code can be found on the DBIC docs as an example. > 6. The branchcode is displayed instead of the branchname in the list of ILL > requests. Sounds easy to fix as we embed "branch" (must be library?) Fixed in an upcoming patch. > 7. api/v1/swagger/paths/*.json > "name": "branchcode" > vs > "name": "branch_id" > same with > borrowernumber vs borrower_id > and > biblionumber vs biblio_id I can work on this tomorrow. Today's been enough! -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/