https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502
Katrin Fischer <katrin.fisc...@bsz-bw.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
--- Comment #8 from Katrin Fischer <katrin.fisc...@bsz-bw.de> ---
Hi,
I like what this is trying to do, but at the moment it doesn't work and will
need more work in order to make it in.
1) This patch adds a new routine ModNotesOrder to the C4 namespace.
You should add it to the Koha namespace instead, for example:
Koha::Acq::Order->add_note. It also needs to be covered by unit tests.
2) You change the CSV header, but only add the 2 notes fields. Why not the
ISBN?
3) Entering/saving notes does currently not work for me at all. I think the
input fields in the table take up a lot of space and are not easy to handle. I
suggest taking a look at how adding messages in the patron account works
(button in the toolbar). The change should show immediately (Ajax) or the page
should reload automatically after entering a note (no need to F5).
4) Tiny: The order search uses 'order line' for 'Order no.' - I suggest to also
use order line here to make it consistent.
5) The late orders table can be configured using the column visibility
settings. The new columns need to be added there as well so you can control
when and where they are visible.
6) Last is just an idea/question: If we are showing ISBN, should we show ISSN
too? Maybe a combined column?
1) and 5) are the biggest issues.
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
