https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
Nick Clemens <n...@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #10 from Nick Clemens <n...@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #8) > 1) If you leave the preference empty, the default will show. The default > doesn't include cardnumber, I think it might be good to include it on top. > > 2) When using the preference, the default will still show, so there is no > way to remove fields. Wouldn't it make more sense to use the non-empty pref > instead of the default? For example a lot of libraries don't use the sort > fields and could remove them from the list this way. > > The current behaviour seems especially confusing since the preference is not > empty by default but includes a list of values. Deleting one of them will > have no effect as long as the value is in the list of default. > > Failing for 2). 1 - Attached patch (this may be better as its own report) 2 - I think this is beyond scope here. The preference is intended to simply control the fields searched when using a 'standard' search. Adding these the dropdown is a convenience feature. I think removing fields is better done by javascript for customization. The list of fields here and the list in the pref didn't have parity before so introducing now would be a bigger change. Moving back to QA queue for second opinion -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/