https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477
Jon Knight <j.p.kni...@lboro.ac.uk> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
CC| |j.p.kni...@lboro.ac.uk
--- Comment #11 from Jon Knight <j.p.kni...@lboro.ac.uk> ---
(In reply to Jonathan Druart from comment #6)
> (In reply to Jonathan Druart from comment #3)
> > Please provide tests!
>
> Reading the code the change is obvious (the same call exists for other
> methods), but why do we call $self->SUPER::store instead of $self->store?
>
> Back to NQA
I just had a look at this and it would appear to call the parent's store method
because if it calls its own there's a loop: the $self->store() method in
Koha/ArticleRequest.pm can call its $self->open() method. I tested it by doing
the obvious: replacing $self-SUPER::store with $self->store and sure enough its
a memory hogging loop that crashed by dev VM's web server.
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
