https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19452
--- Comment #19 from Marcel de Rooy <m.de.r...@rijksmuseum.nl> --- Created attachment 72000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72000&action=edit Bug 19452: [17.11.x] Remove the truncate option The truncate option is not really useful. Its result is probably not what most users of this script expect or need. It truncates both tables borrower_message_preferences and borrower_message_transport_preferences. This (unfortunately) includes deleting messaging preferences for patron categories. After that, adding preferences again will not add categories again, but only borrower preferences which are all disabled. Furthermore, we do not need to disable the foreign key check. Neither do we actually need to truncate, deleting records seems sufficient. Also deleting transport preferences is not needed, since it will be done by a cascade from messaging preferences. Note that the subsequent call of SetMessagingPreferencesFromDefaults will already delete the records. This makes it possible to remove the truncate option altogether. Test plan: [1] Select a patron category (say ST) and change days_in_advance to x. [2] Select a ST patron and set days_advance to y in his msg prefs. [3] Run borrowers-force-messaging-defaults.pl -doit [4] Verify that the patron has been reset to the default prefs (incl. value x in days_in_advance). [5] Verify that the patron category prefs are still intact. Signed-off-by: Marcel de Rooy <m.de.r...@rijksmuseum.nl> Signed-off-by: Charles Farmer <charles.far...@inlibro.com> Signed-off-by: Nick Clemens <n...@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
