https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20248
Alex Arnaud <alex.arn...@biblibre.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
--- Comment #8 from Alex Arnaud <alex.arn...@biblibre.com> ---
Here is my first QA review:
1) please check indenting, mainly in templates (i see some "2 spaces"),
2) you could provide unit tests for create_index function. Take a look at one
wrote for update_index in t/db_dependent/Koha_Elasticsearch_Indexer.t. Don't
forget to delete this "test" index after (which is not done for update_index).
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
