https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19520
--- Comment #10 from Josef Moravec <josef.mora...@gmail.com> --- (In reply to M. Tompsett from comment #5) > Comment on attachment 72819 [details] [review] > Bug 19520: Update database > > Review of attachment 72819 [details] [review]: > ----------------------------------------------------------------- > > ::: > installer/data/mysql/atomicupdate/ > Bug19520_Add_more_information_to_rotating_collections.perl > @@ +5,5 @@ > > + $dbh->do( "ALTER TABLE collections ADD CONSTRAINT `collections_ibfk_2` > > FOREIGN KEY (`createdBy`) REFERENCES `borrowers` (`borrowernumber`) ON > > DELETE SET NULL ON UPDATE CASCADE"); > > + > > + $dbh->do( "ALTER TABLE collections ADD COLUMN createdOn datetime > > default NULL AFTER createdBy" ); > > + > > + $dbh->do( "ALTER TABLE collections ADD COLUMN lastTransferredOn > > datetime default NULL AFTER createdOn" ); > > These 4 do's should be encapsulated by !column_exists checks. > > @@ +10,5 @@ > > + > > + # or perform some test and warn > > + # if( !column_exists( 'biblio', 'biblionumber' ) ) { > > + # warn "There is something wrong"; > > + # } > > And you don't need comments. :) Done, thanks ;) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/