https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19457
Katrin Fischer <katrin.fisc...@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA --- Comment #9 from Katrin Fischer <katrin.fisc...@bsz-bw.de> --- (In reply to Jonathan Druart from comment #8) > I need a confirmation here. > > The test plan says "Set CheckPrevCheckout to Do, or Do, with confirmation", > but it's "unless overriden, do". That means we should check the patron > category and patron's settings as well. > > Finally it sounds like this flag is set when the error/warning must be > displayed, and maybe the following code would be enough: > > } elsif ($confirmation eq 'PREVISSUE') { > $self->screen_msg("This item was previously checked out by you"); > last; > } > > Could someone confirm or tell me what I am missing? There is no setting on patron category here - so this is alright. The pref has 4 values that seem a little confusing. https://bywatersolutions.com/2017/10/09/koha-tutorial-check-previous-checkouts/ I feel the patch is correct. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/