https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893
--- Comment #17 from David Gustafsson <glask...@gmail.com> --- Thanks > 1.) Incomplete fields should be handled more gracefully... I agree. Have ignored this since only results in a warning, but could probably be done in better way. Some mappings ranges in the mappings YAML are off by one (mostly the ff*-fields I think), this might aggravate the issue. > 2.) es_id is missing from the indexed records compared to the Catmandu > indexing code. Is this intentional? I think this is something Catmandu adds, and I think I just left it out since doesn't seems to be needed for anything. > 3.) I think this, when done, should just replace the Catmandu-based indexing > code. Since the ES support itself is somewhat experimental, it would make > sense to switch once and for all. That would be wonderful. I would actually love to get rid of all Catmandu-dependencies altogether. Indexing is probably the heaviest part, the rest should be quite trivial to replace with Search::Elasticsearch (which Catamndu uses internally). > 4.) Make sure to document the dependency on Search::Elasticsearch. Would it > be possible to use the v6 module? It says it supports ES 5 too. I had to > downgrade it on my system for the patch to work. I did not document it since Catmandu depends on it, but it will need to be done if Catmandu is no longer a dependency. To use v6 you just have to change, client => "5_0::Direct" to client => "6_0::Direct". If I'm not mistaken, I think we are running ES 6 with the "5_0::Direct" line (and works, but probably not optimal). The reason I went for 5.0 was that was the version Koha was using at the time of the initial version of the patch (I think). > 5.) Booleans should be indexed as true/false. I'm seeing deprecation notices > for suppress and onloan (this is wrong in the old code too, but could as well > be done correctly here). I agree. This is a problem in Koha master as well I think (but there is a bugzilla issue that takes care of it). It would be easy to fix so will make sure to do so. > 6.) The Catmandu version seems to create way more __sort fields, but perhaps > it's a bug in the Catmandu version? Yes, I think this is a bug in Koha master, but will look into to it. > 7.) The patch doesn't apply cleanly, so there could be also something I > screwed up while fixing it manually. I think you got it right, most of the above I have run into myself, though a bit strange that you had to downgrade to 5.0 to get it to work? Can verify tomorrow that it really is 6.x we are running. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
