https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402
--- Comment #57 from Julian Maurice <julian.maur...@biblibre.com> --- (In reply to Martin Renvoize from comment #54) > Comment on attachment 74380 [details] [review] > Bug 20402: Implement OAuth2 authentication for REST API > > Review of attachment 74380 [details] [review]: > ----------------------------------------------------------------- > > ::: Koha/REST/V1/Auth.pm > @@ +116,5 @@ > > + if (my $oauth = $c->oauth) { > > + my $clients = C4::Context->config('api_client'); > > + $clients = [ $clients ] unless ref $clients eq 'ARRAY'; > > + my ($client) = grep { $_->{client_id} eq $oauth->{client_id} } > > @$clients; > > + > > Actually.. I'm confused.. why do we check against the clients array for a > second time.. We've already tested against this at the 'issue a token' > stage.. or is this your idea of 'revoking a client'? We need the $client hashref to get the patron_id defined in $KOHA_CONF. Please note that this code is removed by bug 20612, which allows to define client_id/secret pairs in the interface instead of in $KOHA_CONF -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/