https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191
--- Comment #58 from Kyle M Hall <k...@bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #56)
> 1. There is 'Account Writeoff' vs 'Account writeoff'
>
> 2. In Koha::Account->pay, why require C4::Letters; instead of use?
>
> 3. Koha/Account.pm:273
> lang => Koha::Patrons->find( $self->{patron_id} )->lang,
> No need to refetch the patron object, you did it already at the beginning of
> the method.
>
> 4. Koha/Account.pm:280
> offsets => scalar Koha::Account::Offsets->search( { id => { -in => [ map {
> $_->id } @account_offsets ] } } ),
>
> I do not understand this line, we are refetching what we already have?
Follow addresses everything but 2. I used require instead of use because use is
hoisted and it would import it even if the feature is not being used. Basically
it's a small efficiency improvement.
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
