https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17530
--- Comment #26 from Jonathan Druart <jonathan.dru...@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #24) > (In reply to Jonathan Druart from comment #23) > > I have not tested it, just had a quick look. > Thats a good start ;) > > > 1. > > This: > > Koha::Biblio->may_article_request > > shows that Koha::Biblio is not the right place to put it. Koha::Object class > > should not have class methods. > Yes, this was arbitrary. I could move it to Koha::ItemType. What do you > think? > > 4. Maybe we do not need may_article_request, but only > > guess_article_requestable_itemtypes? > See point 1. If we remove it, there is no need to move it... I do not understand your point. > > 3. The cache is cleared in a very lazy way :) > Lazy is good enough here imo. I do not think so, the cache is flushed every time the page is hit. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/