https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #97 from Marcel de Rooy <m.de.r...@rijksmuseum.nl> --- (In reply to Victor Grousset/tuxayo from comment #96) > I followed this example: > https://metacpan.org/pod/Number::Format#unformat_number($formatted) OK If you feel the name is good enough, keep it. No big deal. Just do not use formating, single t :) > > So thousands separators come at the expense of handling both dots and > > commas. > > Still opt for something that is more understandable. > I'm not sure to understand. Is the the current state the patch on this topic > acceptable? Would it be clearer if you would say that you c/should not use characters from the DecimalSeparator pref also as thousands separator? > I split the patch because the test plan was way too long. > http://irc.koha-community.org/koha/2018-03-30#i_2024887 > http://irc.koha-community.org/koha/2018-03-30#i_2024900 > > When this bug and bug 18723[1] will be in master there won't be more > fragmentation than today. > And less actually. > > locally: acquisitions and payments/fines will be internally less fragmented. > as there are currently different behaviors in *successive pages* [2] > globally: the new approach replaces an existing one (I checked that it not > used elsewhere) > see moneyFormat function. > > https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75127&action=diff > > So, are these changes a step in the right direct worth of begin integrated? > TODO wait answer, blocking question Well, I just hope so. But willing to follow your argument. Feel free to submit the tiny adjustments you intend to, and I will try to finish here. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
