https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Martin Renvoize <martin.renvo...@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75957|0 |1 is obsolete| | --- Comment #133 from Martin Renvoize <martin.renvo...@ptfs-europe.com> --- Created attachment 78634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78634&action=edit Bug 12310: (follow-up) Fix forgotten writeoff amount field This is a follow up for this forgotten field. See main patch more details. == Test plan == 1. Use a translation of the staff interface if possible. 2. Go to a patrons's page → fines → pay fines 3. Click on "Write off" This assumes an existing debt. Which should exists if you just tested the previous patches. 4. If you enter "1,50", the writeoff amount saved is only 1. This is the bug. 5. Apply this patch 6. run ~/src/installer/data/mysql/updatedatabase.pl 7. Refresh the page 8. Retry the write off. Apply the annex 1 to the "Writeoff amount" field 9. It works! \o/ === Annex 1: Subpart for each concerned page === 1. Set DecimalSeparators syspref to ",." 2. Input "12,34" 3. Press the "Tab/Tabulation" key. It will unfocus the field and trigger the conversion. Validating the form does the same but it's a trick to test more quickly by not switching to another page. 4. The value should have been converted to 12.34 5. Do the same with "12,34 EUR" and ensure that it's converted to "12,34" Same with "EUR 12.34" -> "12.34" 6. "EUR 12.34€thanks lyonthree" -> "12.34" 7. "123 456,7" -> "123456.7" 8.. "2" -> "2" 9.. "2,0" -> "2.0" 10. "-1'345.95" -> "-1345.95" 11. ",1234" -> ".1234" 12. Set DecimalSeparators syspref to "," 13. Reload the page with the form 14. "1.000" -> "1000" 15. "1.000.000,10" -> "1000000.10" 16. Set DecimalSeparators syspref to "." 17. Reload the page with the form 18. "1,000" -> "1000" 19. "1,000,000.10" -> "1000000.10" 20. Validate the form and check that the final value with the dot was 21 well handled. 22. Think about Koalas and smile. 🐨🐨🐨 Signed-off-by: Sonia Bouis <sonia.bo...@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/