https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21560
--- Comment #23 from Martin Renvoize <martin.renvo...@ptfs-europe.com> --- Comment on attachment 85264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85264 Bug 21560: create Koha::Util::OpenDocument with subroutine for ODS generation Review of attachment 85264: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=21560&attachment=85264) ----------------------------------------------------------------- Generally, this is a nice improvement and refactors thanks.. one tiny remark on two lines and I think we can push this over the finish line. ::: misc/cronjobs/gather_print_notices.pl @@ +275,5 @@ > } > } > + > + # Process > + use Koha::Util::OpenDocument; I realise the script has inlined the use statements previously, but any chance we could use this opportunity to tidy up a little and put this at the top of the file for consistency.. I nearly failed the patch thinking it was missing. ::: reports/guided_reports.pl @@ +938,4 @@ > } > > + # Process > + use Koha::Util::OpenDocument; Another case of can we move the use statement to the top. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/