https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817
Liz Rea <wizzy...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Failed QA
CC| |wizzy...@gmail.com
--- Comment #6 from Liz Rea <wizzy...@gmail.com> ---
Hi Devinim,
Thanks for looking at this feature, it will be really cool.
This works well populating item values from a staged record. I don't
particularly like the UX of adding the two items (the "add item" button is hard
to spot in the long list of fields), but that isn't related to this patch.
There are some QA fails here:
FAIL koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt
FAIL filters
missing_filter at line 328 (
<input type="hidden" name="tag" value="[% iteminfo.tag %]" />)
missing_filter at line 309 (
<label class="required">[% iteminfo.subfield %] - [% iteminfo.marc_lib
%]</label>)
missing_filter at line 777 ( [% jsinclude # Parse the page
template's JavaScript block if necessary %])
missing_filter at line 329 (
<input type="hidden" name="subfield" value="[% iteminfo.subfield %]" />)
missing_filter at line 330 (
<input type="hidden" name="mandatory" value="[% iteminfo.mandatory %]" />)
missing_filter at line 311 (
<label>[% iteminfo.subfield %] - [% iteminfo.marc_lib %]</label>)
missing_filter at line 307 ( <div
class="subfield_line" id="subfield[% iteminfo.serialid %][% iteminfo.countitems
%][% iteminfo.subfield %][% iteminfo.random %]">)
missing_filter at line 319 (
<option value="[% value %]">[% iteminfo.marc_value.labels.$value
%]</option>)
missing_filter at line 326 (
<input type="hidden" name="itemid" value="[% itemID %]" />)
missing_filter at line 324 (
[% iteminfo.marc_value %])
missing_filter at line 327 (
<input type="hidden" name="kohafield" value="[% iteminfo.kohafield %]" />)
missing_filter at line 337 ( <input
class="addItemControl" name="buttonPlus" style="cursor:pointer; margin:0 1em;"
onclick="addItem(this,'[% UniqueItemFields %]')" value="Add item"
type="button">)
missing_filter at line 299 ( <div
id="itemblock[% itemID %]" >)
missing_filter at line 317 (
<option value="[% value %]" selected="selected">[%
iteminfo.marc_value.labels.$value %]</option>)
missing_filter at line 342 ( <input
class="addItemControl" name="buttonAddMulti"" style="cursor:pointer;
margin:0 1em;" onclick="checkCount( this ,'[% UniqueItemFields %]')"
value="Add" type="button">)
missing_filter at line 303 ( <li
style="[% iteminfo.hidden %];">)
* Commit title does not start with 'Bug XXXXX: ' - 034220c0cc
Fix those up and I'll sign off on this for you. :)
Cheers,
Liz
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
