https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22451
--- Comment #9 from Josef Moravec <josef.mora...@gmail.com> --- (In reply to Jonathan Druart from comment #5) > 1. I'd say there is a dot missing: > $1$2$3 should be $1.$2$3 to match the value in the DB $1 is for first two version parts with dot... so dot is here, but I agree it is not obvious... maybe better to format regex with 4 parts to make it better readable - i updated the first patch > > 2. I do not understand the changes in the tests. When database is not fully updated, then the test could fail if using version preference... maybe a bit -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/